Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lang): Update el.json #8848

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(lang): Update el.json #8848

merged 2 commits into from
Sep 10, 2024

Conversation

manosvelivasakis
Copy link
Contributor

Description

Updated Greek translation.

Specific Changes proposed

  • Added some missing translations on el.json.
  • Updated translations-needed.md.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@welcome Welcome
Copy link

welcome bot commented Aug 28, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

mister-ben
mister-ben approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (1128425) to head (eabfabd).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8848      +/-   ##
==========================================
- Coverage   83.85%   83.21%   -0.65%     
==========================================
  Files         120      120              
  Lines        8066     8066              
  Branches     1937     1937              
==========================================
- Hits         6764     6712      -52     
- Misses       1302     1354      +52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added patch This PR can be added to a patch release. and removed needs: LGTM Needs one or more additional approvals labels Aug 28, 2024
@adrums86
Copy link
Contributor

Merging this before the next tag/release.

@adrums86 adrums86 merged commit 1e2ea61 into videojs:main Sep 10, 2024
10 of 11 checks passed
@welcome Welcome
Copy link

welcome bot commented Sep 10, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@kerasus kerasus mentioned this pull request Oct 2, 2024
Open
@nerds-github nerds-github mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mister-ben mister-ben mister-ben approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manosvelivasakis @adrums86 @gkatsev @mister-ben